Skip to content

fix: Remove publishing doc on develop version and fix missing leading 0 in version #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Dec 28, 2021

Conversation

ijemmy
Copy link
Contributor

@ijemmy ijemmy commented Dec 28, 2021

Description of your changes

  • Remove publishing doc on develop version. Currently, it's the same as latest version
  • Fix missing leading 0 on the version number (e.g. .2.0 instead of 0.2.0)

How to verify this change

Verified by pushing to another branch and execute this workflow

Related issues, RFCs

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published in downstream module
  • The PR title follows the conventional commit semantics

Breaking change checklist

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ijemmy ijemmy requested review from flochaz and saragerion December 28, 2021 14:49
@dreamorosi dreamorosi merged commit 44991bc into main Dec 28, 2021
@dreamorosi dreamorosi deleted the fix/remove-on-docs-change-workflow branch December 28, 2021 15:11
@heitorlessa heitorlessa added the internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) label Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants