test(metrics): migrate tests to vitest & refactor #3355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
dependencies
pull-request-size
bot
added
the
size/XXL
am29d
requested changes
Nov 25, 2024
Co-authored-by: Alexander Schueren <sha@amazon.com>
|
am29d
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
This PR introduces significant refactoring to the unit tests of the Metrics utility to streamline the test structure and prioritize observing the actual side effects of certain actions, rather than assessing values in the internal implementation.
The PR follows a similar philosophy to a previous one opened for Logger, where I went through all the existing tests and refactored them. For example, except for rare cases, most of the tests observe and perform assertions on the metrics emitted by the utility rather than looking at the implementation of the class.
At the same time, the PR also moves the tests off Jest in favor of vitest. Coverage remained the same, but tests have been split into smaller and more focused files since the previous structure had most of the tests in a single 2K+ LOC file.
Issue number: closes #2821, closes #3354
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.