-
Notifications
You must be signed in to change notification settings - Fork 157
feat(tracer): middy middleware #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
docs/core/tracer.md
Outdated
@@ -107,8 +106,7 @@ You can quickly start by importing the `Tracer` class, initialize it outside the | |||
} | |||
``` | |||
|
|||
<!-- TODO: Replace name of middleware once implemented --> | |||
When using thes `captureLambdaHanlder` decorator or the `TBD` middleware, Tracer performs these additional tasks to ease operations: | |||
When using the `captureLambdaHanlder` decorator or middleware, Tracer performs these additional tasks to ease operations: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor fix:
When using the `captureLambdaHanlder` decorator or middleware, Tracer performs these additional tasks to ease operations: | |
When using the `captureLambdaHandler` decorator or middleware, Tracer performs these additional tasks to ease operations: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
docs/core/tracer.md
Outdated
} | ||
``` | ||
!!! info | ||
We currently support a middleware for tracing methods, [let us know](https://github.com/awslabs/aws-lambda-powertools-typecsript/issues/new?assignees=&labels=feature-request%2C+triage&template=feature_request.md&title=) if you'd like to see one! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor fix:
We currently support a middleware for tracing methods, [let us know](https://github.com/awslabs/aws-lambda-powertools-typecsript/issues/new?assignees=&labels=feature-request%2C+triage&template=feature_request.md&title=) if you'd like to see one! | |
We currently support a middleware for tracing methods, [let us know](https://github.com/awslabs/aws-lambda-powertools-typescript/issues/new?assignees=&labels=feature-request%2C+triage&template=feature_request.md&title=) if you'd like to see one! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for spotting this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, some minor comments
Description of your changes
Implement middy-based middleware with feature parity against captureMethod decoratorHow to verify this change
Checkout branch & run
npm run tests
insrc/packages/tracing
and/or observe actions results.Related issues, RFCs
#295
#282
PR status
Is this ready for review?: NO
Is it a breaking change?: NO
Checklist
Breaking change checklist
N/A
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.