-
Notifications
You must be signed in to change notification settings - Fork 157
chore(ALL): fix packaging #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
9ed1313
fix linting
flochaz a0e58d6
fix npm access
flochaz 14e7eb4
fix lint
flochaz a0177a7
chore(metrics): fix packaging by using shared commons module
flochaz 8a37a94
chore(metrics): fix packaging by using shared commons module
flochaz 8306fca
Merge remote-tracking branch 'origin/main' into fix/packaging
flochaz 3ad2470
chore(tracing): fix packaging
flochaz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,63 +1,77 @@ | ||
module.exports = { | ||
env: { | ||
'browser': false, | ||
'es2020': true, | ||
'jest': true, | ||
'node': true, | ||
browser: false, | ||
es2020: true, | ||
jest: true, | ||
node: true, | ||
}, | ||
extends: [ | ||
'plugin:@typescript-eslint/eslint-recommended', | ||
'plugin:@typescript-eslint/recommended' | ||
], | ||
extends: ['plugin:@typescript-eslint/eslint-recommended', 'plugin:@typescript-eslint/recommended'], | ||
parser: '@typescript-eslint/parser', | ||
plugins: ['@typescript-eslint'], | ||
settings: { | ||
'import/resolver': { | ||
node: {}, | ||
typescript: { | ||
project: './tsconfig.es.json', | ||
alwaysTryTypes: true, | ||
}, | ||
}, | ||
}, | ||
rules: { | ||
'@typescript-eslint/ban-ts-ignore': ['off'], | ||
'@typescript-eslint/camelcase': ['off'], | ||
'@typescript-eslint/explicit-function-return-type': [ 'error', { 'allowExpressions': true } ], | ||
'@typescript-eslint/explicit-function-return-type': ['error', { allowExpressions: true }], | ||
'@typescript-eslint/explicit-member-accessibility': 'error', | ||
'@typescript-eslint/indent': [ 'error', 2, { 'SwitchCase': 1 } ], | ||
'@typescript-eslint/indent': ['error', 2, { SwitchCase: 1 }], | ||
'@typescript-eslint/interface-name-prefix': ['off'], | ||
'@typescript-eslint/member-delimiter-style': [ 'error', { 'multiline': { 'delimiter': 'none' } } ], | ||
'@typescript-eslint/member-ordering': [ 'error', { | ||
'default': { 'memberTypes': [ | ||
'signature', | ||
'public-field', // = ["public-static-field", "public-instance-field"] | ||
'protected-field', // = ["protected-static-field", "protected-instance-field"] | ||
'private-field', // = ["private-static-field", "private-instance-field"] | ||
'constructor', | ||
'public-method', // = ["public-static-method", "public-instance-method"] | ||
'protected-method', // = ["protected-static-method", "protected-instance-method"] | ||
'private-method' // = ["private-static-method", "private-instance-method"] | ||
] , | ||
'order': 'alphabetically' } | ||
} ], | ||
'@typescript-eslint/member-delimiter-style': ['error', { multiline: { delimiter: 'none' } }], | ||
'@typescript-eslint/member-ordering': [ | ||
'error', | ||
{ | ||
default: { | ||
memberTypes: [ | ||
'signature', | ||
'public-field', // = ["public-static-field", "public-instance-field"] | ||
'protected-field', // = ["protected-static-field", "protected-instance-field"] | ||
'private-field', // = ["private-static-field", "private-instance-field"] | ||
'constructor', | ||
'public-method', // = ["public-static-method", "public-instance-method"] | ||
'protected-method', // = ["protected-static-method", "protected-instance-method"] | ||
'private-method', // = ["private-static-method", "private-instance-method"] | ||
], | ||
order: 'alphabetically', | ||
}, | ||
}, | ||
], | ||
'@typescript-eslint/no-explicit-any': 'error', | ||
'@typescript-eslint/no-inferrable-types': ['off'], | ||
'@typescript-eslint/no-unused-vars': [ 'error', { 'argsIgnorePattern': '^_' } ], | ||
'@typescript-eslint/no-unused-vars': ['error', { argsIgnorePattern: '^_' }], | ||
'@typescript-eslint/no-use-before-define': ['off'], | ||
'@typescript-eslint/semi': [ 'error', 'always' ], | ||
'array-bracket-spacing': [ 'error', 'always', { 'singleValue': false } ], | ||
'arrow-body-style': [ 'error', 'as-needed' ], | ||
'computed-property-spacing': [ 'error', 'never' ], | ||
'func-style': [ 'warn', 'expression' ], | ||
'indent': [ 'error', 2, { 'SwitchCase': 1 } ], | ||
'@typescript-eslint/semi': ['error', 'always'], | ||
'array-bracket-spacing': ['error', 'always', { singleValue: false }], | ||
'arrow-body-style': ['error', 'as-needed'], | ||
'computed-property-spacing': ['error', 'never'], | ||
'func-style': ['warn', 'expression'], | ||
indent: ['error', 2, { SwitchCase: 1 }], | ||
'keyword-spacing': 'error', | ||
'newline-before-return': 2, | ||
'no-console': 0, | ||
'no-multi-spaces': [ 'error', { 'ignoreEOLComments': false } ], | ||
'no-multiple-empty-lines': [ 'error', { 'max': 1, 'maxBOF': 0 } ], | ||
'no-multi-spaces': ['error', { ignoreEOLComments: false }], | ||
'no-multiple-empty-lines': ['error', { max: 1, maxBOF: 0 }], | ||
'no-throw-literal': 'error', | ||
'object-curly-spacing': [ 'error', 'always' ], | ||
'object-curly-spacing': ['error', 'always'], | ||
'prefer-arrow-callback': 'error', | ||
'quotes': [ 'error', 'single', { 'allowTemplateLiterals': true } ], | ||
'semi': [ 'error', 'always' ], | ||
'sort-imports': [ 'error', { | ||
'allowSeparatedGroups': true, | ||
'ignoreCase': true, | ||
'ignoreDeclarationSort': false, | ||
'ignoreMemberSort': true, | ||
'memberSyntaxSortOrder': [ 'all', 'single', 'multiple', 'none' ] | ||
} ] | ||
} | ||
}; | ||
quotes: ['error', 'single', { allowTemplateLiterals: true }], | ||
semi: ['error', 'always'], | ||
'sort-imports': [ | ||
'error', | ||
{ | ||
allowSeparatedGroups: true, | ||
ignoreCase: true, | ||
ignoreDeclarationSort: false, | ||
ignoreMemberSort: true, | ||
memberSyntaxSortOrder: ['all', 'single', 'multiple', 'none'], | ||
}, | ||
], | ||
}, | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
packages/logger/examples/utils/formatters/CustomLogFormatter.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
packages/logger/examples/utils/formatters/MyCompanyLogFormatter.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not disagreeing, just curious: why do we need a tsconfig-dev vs prod?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I explained it in pr details but basically we need one for eslint and for packaging to get everything lint but just src packaged