-
Notifications
You must be signed in to change notification settings - Fork 156
feat(batch): add option to not throw FullBatchFailureError
when the entire batch fails
#2711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dreamorosi
merged 12 commits into
aws-powertools:main
from
arnabrahman:2122-not-throw-full-batch-failure
Jul 9, 2024
Merged
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
118b735
feat: `throwOnFullBatchFailure` option for `BatchProcessingOptions`
arnabrahman 9ccfb13
feat: check `throwOnFullBatchFailure` option while throwing `FullBatc…
arnabrahman dba0f44
test: process partial response function call with asynchronous handle…
arnabrahman 52aca96
test: process partial response through handler for full batch failure
arnabrahman a491971
test: processPartialResponseSync for full batch failure with `throwOn…
arnabrahman ea8a020
doc: update do block for process functions
arnabrahman c01e2d6
doc: mention `throwOnFullBatchFailure` in all records failed section
arnabrahman db1a541
chore: add period to sentence
dreamorosi e945093
docs(batch): added new option to dosc
dreamorosi 37bd666
docs(batch): rephrase paragraph
dreamorosi 2295b0b
Merge branch 'main' into 2122-not-throw-full-batch-failure
dreamorosi f4e7e1b
Merge branch 'main' into 2122-not-throw-full-batch-failure
am29d File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
import { | ||
BatchProcessor, | ||
EventType, | ||
processPartialResponse, | ||
} from '@aws-lambda-powertools/batch'; | ||
import type { SQSHandler, SQSRecord } from 'aws-lambda'; | ||
|
||
const processor = new BatchProcessor(EventType.SQS); | ||
|
||
const recordHandler = async (_record: SQSRecord): Promise<void> => { | ||
// Process the record | ||
}; | ||
|
||
export const handler: SQSHandler = async (event, context) => | ||
processPartialResponse(event, recordHandler, processor, { | ||
context, | ||
throwOnFullBatchFailure: false, | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.