fix(ci): create one layer artifact per region & merge #2095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Merged
10 tasks
|
looking |
heitorlessa
changed the title
pull-request-size
bot
added
size/S
heitorlessa
reviewed
Feb 20, 2024
There was a problem hiding this comment.
in case you want to sync the write vs append behavior too (until we have a central Actions repo working for everyone cc @sthulb)
heitorlessa
approved these changes
Feb 20, 2024
|
sthulb
approved these changes
Feb 20, 2024
sthulb
deleted the
2042-maintenance-refactor-artifact-name-strategy-for-parallel-uploads
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR slightly modifies the implementation of the CI workflows that handle the Lambda layer publishing and subsequent documentation updates.
Whenever we publish a new Lambda layer version we need to update the ARNs in the documentation. This is done via a combination of CFN outputs, CDK output file, and GitHub artifacts.
Since the layer publishing happens for multiple AWS Regions in parallel, the Layer ARN for each region gets added to a text file that should be uploaded as GitHub artifact. Prior to this PR the artifacts were overwriting each others and ultimately we were looking at one ARN only.
This PR restores the upload of multiple GitHub artifacts by appending the
${{ matrix.region }}variable to the artifact name. Additionally, the PR also modifies how the artifacts are consumed by adding themerge-multiple: truesetting to the step that downloads the Layer artifacts so that all the Layer ARNs are actually considered when updating the docs.Related issues, RFCs
Issue number: closes #2042
Checklist
Breaking change checklist
Is it a breaking change?: NO
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.