Skip to content

chore(ci): fix make-version workflow on detached head #2093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

am29d
Copy link
Contributor

@am29d am29d commented Feb 19, 2024

Description of your changes

In a previous PR I have changed github.ref to github.sha because this is more contained for workflow. Because using sha worked in our release workflow and we don't allow lerna to push back to the git repo, I have assumed that lerna version will behave similar, because we use --no-git-tag-version --no-push, which means there is no need to for git history or any additional information lerna to just bump the version.

It turns out, that this is an open issue since the dawn of time, lerna/lerna#2443 and lerna wants to have git history, even if you pass the flag not to operate on git.

I have tested the publish with github.sha checkout option and it worked, so we can keep the make-release workflow as it is.

Related issues, RFCs

Issue number: closes #2092

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@am29d am29d requested a review from a team February 19, 2024 17:17
@boring-cyborg boring-cyborg bot added the automation This item relates to automation label Feb 19, 2024
@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Feb 19, 2024
@am29d am29d requested a review from dreamorosi February 19, 2024 17:17
@am29d am29d self-assigned this Feb 19, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@dreamorosi
Copy link
Contributor

I think lerna still needs to access git to be able to derive the new version and populate the change log files.

Thanks for fixing it!

@dreamorosi dreamorosi merged commit b395d9a into main Feb 20, 2024
@dreamorosi dreamorosi deleted the fix/make-version-workflow branch February 20, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation size/XS PR between 0-9 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: fix versioning workflow failing on git detached head
2 participants