chore(ci): fix make-version workflow on detached head #2093
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
In a previous PR I have changed
github.ref
togithub.sha
because this is more contained for workflow. Because using sha worked in our release workflow and we don't allow lerna to push back to the git repo, I have assumed thatlerna version
will behave similar, because we use--no-git-tag-version --no-push
, which means there is no need to for git history or any additional informationlerna
to just bump the version.It turns out, that this is an open issue since the dawn of time, lerna/lerna#2443 and lerna wants to have git history, even if you pass the flag not to operate on git.
I have tested the publish with
github.sha
checkout option and it worked, so we can keep themake-release
workflow as it is.Related issues, RFCs
Issue number: closes #2092
Checklist
Breaking change checklist
Is it a breaking change?: NO
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.