Skip to content

chore(ci): fix docs workflow permissions #2000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Conversation

dreamorosi
Copy link
Contributor

Description of your changes

This PR adds new permissions to the rebuild_latest_docs.yml and on_doc_merge.yml to match the permissions requested by the reusable workflow called by both (reusable_publish_docs.yml).

The reusable workflow requires contents: read to be able to read the repository contents, however the two caller workflows were not specifying any content related permission at the job level, implicitly setting it to none and thus causing the workflow runs to fail (example).

With this change the workflows should be able to publish docs again.

Related issues, RFCs

Issue number: #1799

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi requested a review from a team January 31, 2024 17:07
@boring-cyborg boring-cyborg bot added the automation This item relates to automation label Jan 31, 2024
@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Jan 31, 2024
@dreamorosi dreamorosi self-assigned this Jan 31, 2024
@dreamorosi dreamorosi requested a review from am29d January 31, 2024 17:07
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@am29d am29d merged commit 2b179f7 into main Jan 31, 2024
@am29d am29d deleted the chore/fix_docs_workflow branch January 31, 2024 18:45
@dreamorosi dreamorosi linked an issue Feb 1, 2024 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation size/XS PR between 0-9 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: Improve security posture by addressing OpenSSF results
2 participants