Skip to content

feat: Adding sample automation for PR #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 20, 2021
Merged

feat: Adding sample automation for PR #121

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ce5c2b5
Adding sample automation for PR
Jul 20, 2021
968d00e
Adding comment
Jul 20, 2021
284d10d
MOving env var out of script, and setting node version explicitly
Jul 20, 2021
9f42910
trying to merge coverage reports
Jul 20, 2021
2e25bc7
Fixing typo
Jul 20, 2021
db10b11
Exluding dependabot from running coverage collation
Jul 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions .github/workflows/on-pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
name: on-pull-request
on:
pull_request

jobs:
on_pr:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Install packages
run: |
export NODE_ENV=dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd consider setting the environment variable like so

     runs-on: ubuntu-latest
     env:
          NODE_ENV: dev
     steps:
          ...

npm ci
npm run lerna-ci
- name: Run lint
run: npm run lerna-lint
- name: Run tests
run: npm run lerna-test
- name: Report Coverage
#Dependabot user will only have read-only perms, so don't try to report coverage
if: ${{ github.actor != 'dependabot[bot]' }}
uses: romeovs/lcov-reporter-action@v0.2.21
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
lcov-file: ./packages/logger/coverage/lcov.info
9 changes: 2 additions & 7 deletions .github/workflows/on-push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ on:
jobs:
on_push:
runs-on: ubuntu-latest
if: ${{ github.event_name != 'pull_request' }}
steps:
- uses: actions/checkout@v2
- name: Install packages
Expand All @@ -15,10 +16,4 @@ jobs:
- name: Run lint
run: npm run lerna-lint
- name: Run tests
run: npm run lerna-test
- name: Report Coverage
if: ${{ github.event_name == 'pull_request' }}
uses: romeovs/lcov-reporter-action@v0.2.21
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
lcov-file: ./packages/logger/coverage/lcov.info
run: npm run lerna-test