Skip to content

chore(layer): fix bundling and e2e tests by manually setting hash of asset #1116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

flochaz
Copy link
Contributor

@flochaz flochaz commented Oct 12, 2022

Description of your changes

For some reason bundled layer was not updated properly when version change.
After some investigation it looks like to be related to a bug in lambda.Code.fromAsset which does not take into account a change in bundling local command. Forcing the calculation of the hash based on bundling local command (which include version as well), layer is updated properly.

How to verify this change

Check https://github.com/awslabs/aws-lambda-powertools-typescript/actions/runs/3232406370 or run e2e from your computer

Related issues, RFCs

Issue number: #1114

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding changes to the examples
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published in downstream module
  • The PR title follows the conventional commit semantics

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions github-actions bot added the internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) label Oct 12, 2022
@github-actions
Copy link
Contributor

No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure.

@github-actions github-actions bot added do-not-merge This item should not be merged need-issue This PR needs an issue before it can be reviewed/worked on further labels Oct 12, 2022
@flochaz flochaz marked this pull request as ready for review October 12, 2022 06:10
@dreamorosi dreamorosi removed do-not-merge This item should not be merged need-issue This PR needs an issue before it can be reviewed/worked on further labels Oct 12, 2022
@dreamorosi dreamorosi added this to the Lambda layer milestone Oct 12, 2022
@flochaz flochaz merged commit 3b5c799 into main Oct 13, 2022
@flochaz flochaz deleted the fix/layerE2E branch October 13, 2022 09:35
@github-actions
Copy link
Contributor

@awslabs/aws-lambda-powertools-typescript No related issues found. Please ensure 'pending-release' label is applied before releasing.

1 similar comment
@github-actions
Copy link
Contributor

@awslabs/aws-lambda-powertools-typescript No related issues found. Please ensure 'pending-release' label is applied before releasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants