Skip to content

Feature request: change visibility from private to protected to allow overrides #3376

Closed
@zirkelc

Description

@zirkelc

Use case

As discussed before, I would like to suggest to change the visibility of certain methods of Logger from private to protected to allow overrides by subclassing Logger. A use case for such an override would be the buffering of log messages (see #3178).

If approved, I'm happy to submit a PR.

Solution/User Experience

The following methods could be made protected:

private createAndPopulateLogItem(
logLevel: number,
input: LogItemMessage,
extraInput: LogItemExtraInput
): LogItem {

private printLog(logLevel: number, log: LogItem): void {

private processLogItem(
logLevel: number,
input: LogItemMessage,
extraInput: LogItemExtraInput
): void {

Alternative solutions

Acknowledgment

Future readers

Please react with 👍 and your use case to help us understand customer demand.

Metadata

Metadata

Assignees

Labels

completedThis item is complete and has been merged/shippedfeature-requestThis item refers to a feature request for an existing or new utilityloggerThis item relates to the Logger Utility

Type

No type

Projects

Status

Shipped

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions