Skip to content

Maintenance: run tests on examples only in CI and not on pre-push locally #1106

Closed
@dreamorosi

Description

@dreamorosi

Description of the feature request

Problem statement

At the moment we are running unit tests for all examples every time we are pushing code as a part of the pre-push hooks. This is a relic of a time (a year ago) during which we were using the monorepo/linked version of the utilities in the examples.

Since a long time we have moved the examples to use the published version. This means that even when one of the utilities changes, testing the examples is redundant as they won't be using the changed version.

This issue proposes to remove the unit test run for examples from the pre-push commit. Examples will be tested only as a part of the CI checks in a PR and potentially only when there are changes in the files under examples/*.

Summary of the feature
Remove the examples from the pre-commit, pre-push hooks.

Code examples
N/A

Benefits for you and the wider AWS community
With this change the DX for maintainers will improve as it removes the need of using --no-verify when wanting a faster feedback look.

Describe alternatives you've considered
N/A

Additional context
N/A

Related issues, RFCs

N/A

Metadata

Metadata

Assignees

Labels

automationThis item relates to automationcompletedThis item is complete and has been merged/shippedinternalPRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)testsPRs that add or change tests

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions