-
Notifications
You must be signed in to change notification settings - Fork 433
fix(event-handler): handle aliased parameters e.g., Query(alias="categoryType") #3766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Unsure why this test is failing; works locally. Pushing a no-op code change w/ a rebase, before we investigate further. Edit: global dict mutation race condition w/ running multiple tests. |
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
* develop: chore: cleanup, add test for single and nested fix(parameters): make cache aware of single vs multiple calls
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
This reverts commit f79dffc.
Indeed racing condition. Reverting no-op change, and merging after CI completes all checks. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot for the fix @rubenfonseca 🙌
Issue number: #3732
Summary
Changes
This PR fixes a bug when handling event handler parameters that used aliases.
User experience
After this PR, aliases should be correctly supported.
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.