Skip to content

docs(event_handler): demonstrate how to combine logger correlation ID and middleware #3064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 8, 2023
Merged

docs(event_handler): demonstrate how to combine logger correlation ID and middleware #3064

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0431af9
fix(parameters): make cache aware of single vs multiple calls
heitorlessa Jul 25, 2023
dd5316a
chore: cleanup, add test for single and nested
heitorlessa Jul 25, 2023
b5e1f79
docs(event_handler): use correct correlation_id in logger.set_correla…
heitorlessa Sep 8, 2023
9ddbc12
docs(event_handler): combine correlation id with logger for a more po…
heitorlessa Sep 8, 2023
8cb934b
fix(parameters): make cache aware of single vs multiple calls
heitorlessa Jul 25, 2023
f67fedc
chore: cleanup, add test for single and nested
heitorlessa Jul 25, 2023
7410f5a
Merge branch 'develop' into docs/middleware-correlation-id-var
heitorlessa Sep 8, 2023
9876646
docs: remove Logger dependency on retrieval to address Simon's feedback
heitorlessa Sep 8, 2023
8a55354
docs: fix racing condition, more notes based on Simon's feedback
heitorlessa Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/event_handler_rest/src/middleware_getting_started.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ def inject_correlation_id(app: APIGatewayRestResolver, next_middleware: NextMidd
request_id = app.current_event.request_context.request_id # (1)!

# Use API Gateway REST API request ID if caller didn't include a correlation ID
correlation_id = app.current_event.headers.get("x-correlation-id", request_id)
correlation_id = logger.get_correlation_id() or request_id

# Inject correlation ID in shared context and Logger
app.append_context(correlation_id=correlation_id) # (2)!
Expand All @@ -35,6 +35,6 @@ def get_todos():
return {"todos": todos.json()[:10]}


@logger.inject_lambda_context
@logger.inject_lambda_context(correlation_id_path='headers."x-correlation-id"')
def lambda_handler(event, context):
return app.resolve(event, context)
2 changes: 1 addition & 1 deletion examples/event_handler_rest/src/middleware_global_middlewares_module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def inject_correlation_id(app: APIGatewayRestResolver, next_middleware: NextMidd
request_id = app.current_event.request_context.request_id

# Use API Gateway REST API request ID if caller didn't include a correlation ID
correlation_id = app.current_event.headers.get("x-correlation-id", request_id)
correlation_id = logger.get_correlation_id() or request_id

# Inject correlation ID in shared context and Logger
app.append_context(correlation_id=correlation_id)
Expand Down