-
Notifications
You must be signed in to change notification settings - Fork 431
feat(metrics) - add support for high resolution metrics #1915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
leandrodamascena
merged 11 commits into
aws-powertools:develop
from
leandrodamascena:feat/metrics-high-resolution
Feb 10, 2023
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
0cec3d2
feat(metrics) - Adding high resolution metrics
leandrodamascena 991be42
feat(metrics) - Adding high resolution metrics - tests
leandrodamascena dda29b9
feat(metrics) - Adding high resolution metrics - docs
leandrodamascena deaab2e
feat(metrics) - Adding high resolution metrics - docs
leandrodamascena 85753a4
feat(metrics) - Adding high resolution metrics - fix mypy errors
leandrodamascena 40ce2ac
feat(metrics) - Adding high resolution metrics - revert e2e wrong cha…
leandrodamascena 0e3f933
feat(metrics) - Addressing Heito's feedbacks
leandrodamascena 1e8974f
chore: cover additional logic branches on resolution
heitorlessa 64ff2d3
chore: cleanup test name for consistency
heitorlessa fd2b4d9
fix: make resolution error actionable
heitorlessa c2bb45b
fix: raise resolution error for all invalid options
heitorlessa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
from typing_extensions import NotRequired, TypedDict | ||
|
||
|
||
class MetricNameUnitResolution(TypedDict): | ||
Name: str | ||
Unit: str | ||
StorageResolution: NotRequired[int] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
from aws_lambda_powertools import Metrics | ||
from aws_lambda_powertools.metrics import MetricResolution, MetricUnit | ||
from aws_lambda_powertools.utilities.typing import LambdaContext | ||
|
||
metrics = Metrics() | ||
|
||
|
||
@metrics.log_metrics # ensures metrics are flushed upon request completion/failure | ||
def lambda_handler(event: dict, context: LambdaContext): | ||
metrics.add_metric(name="SuccessfulBooking", unit=MetricUnit.Count, value=1, resolution=MetricResolution.High) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.