Skip to content

Papercuts we're currently prioritizing #857

Closed
@whardier

Description

@whardier

Need to add proper ContextManager typing via typing.ContrxtManager in several places.

Currently overriding single_metric (-> ContextManager[SingleMetric]) and noticed several other areas where this needs done as well.

Also be nice if there was a proper DummySubSegment type returned for tracing provider.in_subsegment to avoid including types from aws modules to cast.

Expected Behavior

Have rich type annotations along for the ride when using context managers.

Current Behavior

Need to self annotate.

Possible Solution

Add in proper type annotation to some or all of the context manager decorated functions.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingdocumentationImprovements or additions to documentation

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions