Skip to content

powertools-parameters module #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Oct 1, 2020

Conversation

jeromevdl
Copy link
Contributor

Description of changes:

Add parameters module, to easily retrieve parameters from SSM Parameter Store and Secrets Manager, put them in cache for further reuse.

Checklist

Breaking change checklist

New module, no impact on other ones, but probably need to increase version accordingly.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pankajagrawal16
Copy link
Contributor

Thanks @jeromevdl for the contribution. I will have a look at the PR.

Copy link
Contributor

@pankajagrawal16 pankajagrawal16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, thanks for this contribution. It will be a great utility to have.

I have few suggestions/questions which I have tried to explain. Let me know your thoughts and we can discuss further.

Regarding docs, I do agree, once we have the code change finalized, then start with documenting it.(Avoids rework)

@msailes
Copy link
Contributor

msailes commented Sep 9, 2020

Could we get an update to an existing example, or a new example to show the developer experience? Thanks.

Copy link
Contributor

@pankajagrawal16 pankajagrawal16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has started to look nice. Some minor suggestion. Also if we could have a test where we can see how clients will use these API directly, will be great. Like end to end but just mocking the client and CacheManager with Clock

Copy link
Contributor

@pankajagrawal16 pankajagrawal16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really nice to me with all the test etc.

We should make sure that we have the docs updated as well to document the utility, either as part of this PR or a separate is ok too.

@jeromevdl
Copy link
Contributor Author

Will create the doc and a sample once this PR is validated.

@msailes
Copy link
Contributor

msailes commented Sep 22, 2020

Will create the doc and a sample once this PR is validated.

Yeah, lets move onto writing the docs and sample!

Copy link
Contributor

@pankajagrawal16 pankajagrawal16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@pankajagrawal16 pankajagrawal16 merged commit a93b984 into aws-powertools:master Oct 1, 2020
@jeromevdl jeromevdl deleted the parameters branch November 4, 2022 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants