chore: upgrade AspectjGradlePlugin to latest and example project to java 11 #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromevdl
previously approved these changes
Nov 20, 2020
pankajagrawal16
force-pushed
the
latest-gradle
branch
from
1454aa9 to
f73570a
Compare
pankajagrawal16
changed the title
vitodegiosa
reviewed
Nov 26, 2020
...re/src/main/java/software/amazon/lambda/powertools/core/internal/LambdaHandlerProcessor.java
Show resolved
Hide resolved
example/template.yaml
Outdated
| @@ -16,7 +16,7 @@ Resources: | |||
| Properties: | |||
| CodeUri: HelloWorldFunction | |||
| Handler: helloworld.App::handleRequest | |||
| Runtime: java8 | |||
| Runtime: java11 | |||
There was a problem hiding this comment.
Does it make sense to add the Runtime to Globals?
There was a problem hiding this comment.
Sure, I can Move to globals
added 5 commits
November 26, 2020 15:27
pankajagrawal16
force-pushed
the
latest-gradle
branch
from
33b05a4 to
7e77f7d
Compare
vitodegiosa
approved these changes
Nov 26, 2020
|
What is the aspectj maven.plugin version that supports jdk 11? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.