Skip to content

refactor: Rename helpers for validation module #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 3, 2020
Merged

Conversation

pankajagrawal16
Copy link
Contributor

@pankajagrawal16 pankajagrawal16 commented Nov 3, 2020

Issue #, if available:

Description of changes:

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jeromevdl
Copy link
Contributor

Maybe also rename ValidatorConfig to ValidationConfig ?

@pankajagrawal16
Copy link
Contributor Author

Maybe also rename ValidatorConfig to ValidationConfig ?

Done

private static final String CLASSPATH = "classpath:";

private static final ConcurrentHashMap<String, JsonSchema> schemas = new ConcurrentHashMap<>();

private ValidationUtils() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@jeromevdl jeromevdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@pankajagrawal16 pankajagrawal16 merged commit 90327a4 into master Nov 3, 2020
@pankajagrawal16 pankajagrawal16 deleted the renaming branch November 3, 2020 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants