-
Notifications
You must be signed in to change notification settings - Fork 90
feat(v2): parallel batch processing #1620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 14 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
7dc7c34
implement parallel processing
jeromevdl d9e809c
test parallel processing
jeromevdl 789b91b
document parallel processing
jeromevdl 1bbad5b
code review
jeromevdl c5be568
sqs // batch processing example
jeromevdl 860d464
rollback to AtomicBoolean
jeromevdl d60a888
Merge branch 'v2' into feat/parallel-batch
jeromevdl af2fda9
Merge branch 'v2' into feat/parallel-batch
jeromevdl 56499e2
Merge branch 'v2' into feat/parallel-batch
jeromevdl b51a6de
Merge branch 'v2' into feat/parallel-batch
jeromevdl 73f100d
complete sqs batch example with logs and traces annotations
jeromevdl 9438151
Merge remote-tracking branch 'origin/feat/parallel-batch' into feat/p…
jeromevdl 1e55a9b
update doc
jeromevdl c35a87a
update doc
jeromevdl 395f37a
update doc
jeromevdl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
70 changes: 70 additions & 0 deletions
70
...s/powertools-examples-batch/src/main/java/org/demo/batch/sqs/AbstractSqsBatchHandler.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
/* | ||
* Copyright 2024 Amazon.com, Inc. or its affiliates. | ||
* Licensed under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
* | ||
*/ | ||
|
||
package org.demo.batch.sqs; | ||
|
||
import com.amazonaws.services.lambda.runtime.Context; | ||
import com.fasterxml.jackson.databind.ObjectMapper; | ||
import java.io.File; | ||
import java.io.IOException; | ||
import java.util.Arrays; | ||
import java.util.Random; | ||
import org.demo.batch.model.Product; | ||
import org.slf4j.Logger; | ||
import org.slf4j.LoggerFactory; | ||
import org.slf4j.MDC; | ||
import software.amazon.awssdk.core.sync.RequestBody; | ||
import software.amazon.awssdk.http.urlconnection.UrlConnectionHttpClient; | ||
import software.amazon.awssdk.services.s3.S3Client; | ||
import software.amazon.awssdk.services.s3.model.PutObjectRequest; | ||
import software.amazon.lambda.powertools.logging.Logging; | ||
import software.amazon.lambda.powertools.tracing.Tracing; | ||
import software.amazon.lambda.powertools.tracing.TracingUtils; | ||
|
||
public class AbstractSqsBatchHandler { | ||
private static final Logger LOGGER = LoggerFactory.getLogger(AbstractSqsBatchHandler.class); | ||
private final ObjectMapper mapper = new ObjectMapper(); | ||
private final String bucket = System.getenv("BUCKET"); | ||
private final S3Client s3 = S3Client.builder().httpClient(UrlConnectionHttpClient.create()).build(); | ||
private final Random r = new Random(); | ||
|
||
/** | ||
* Simulate some processing (I/O + S3 put request) | ||
* @param p deserialized product | ||
* @param context Lambda context | ||
*/ | ||
@Logging | ||
@Tracing | ||
protected void processMessage(Product p, Context context) { | ||
TracingUtils.putAnnotation("productId", p.getId()); | ||
TracingUtils.putAnnotation("Thread", Thread.currentThread().getName()); | ||
MDC.put("product", String.valueOf(p.getId())); | ||
LOGGER.info("Processing product {}", p); | ||
|
||
char c = (char)(r.nextInt(26) + 'a'); | ||
char[] chars = new char[1024 * 1000]; | ||
Arrays.fill(chars, c); | ||
p.setName(new String(chars)); | ||
try { | ||
File file = new File("/tmp/"+p.getId()+".json"); | ||
mapper.writeValue(file, p); | ||
s3.putObject( | ||
PutObjectRequest.builder().bucket(bucket).key(p.getId()+".json").build(), RequestBody.fromFile(file)); | ||
} catch (IOException e) { | ||
throw new RuntimeException(e); | ||
} finally { | ||
MDC.remove("product"); | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.