-
Notifications
You must be signed in to change notification settings - Fork 90
chore: Adding Validation step for IaC with SAM #1498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
e66095e
Setting up Kotlin environment. Converting test to Kotlin.
ea0b496
Deploying via SAM successfully.
615a095
Added Kotlin example.
5199105
Removing unused Gradle build file.
37020f3
Merge branch 'main' into main
scottgerring 6386358
Adding SAM template so can be used as an existing project and Java ta…
19679da
Adding SAM template so can be used as an existing project
17c3a5e
Updating guidance to use SAM for build and deploy
1312c02
Restructuring separate Java and Kotlin examples.
18c7f48
Updating core examples readme to represent new structure for Java and…
d968f3c
Refactoring application code for efficiency, updating build to cover …
5ce71f7
Updating to fix trailing \n
35fbbac
Updating guidance to be more specific for examples
6ffa295
Merge branch 'main' into main
scottgerring d277c5c
Adopting new mechanism for specifying jvm target.
6c4646e
accommodating new project structure
6eecb90
Fixing link typo after refactoring
66a3dc2
Merge branch 'main' into main
scottgerring 1431899
Setting up Kotlin environment. Converting test to Kotlin.
3396766
Deploying via SAM successfully.
baa0e3f
Added Kotlin example.
16380a8
Removing unused Gradle build file.
3f3f4e8
Adding SAM template so can be used as an existing project and Java ta…
9d70b57
Adding SAM template so can be used as an existing project
bcff275
Updating guidance to use SAM for build and deploy
84935c9
Restructuring separate Java and Kotlin examples.
bf6da0d
Updating core examples readme to represent new structure for Java and…
f67f59a
Refactoring application code for efficiency, updating build to cover …
f7288d5
Updating to fix trailing \n
f03b01b
Updating guidance to be more specific for examples
e523554
Adopting new mechanism for specifying jvm target.
a71e263
accommodating new project structure
51fc239
Fixing link typo after refactoring
6cef711
Flattening structure back to original to make merging easier for v2
2444ba4
Merge remote-tracking branch 'origin/main'
c24ee6d
Adding build for Kotlin Gradle
de19b56
Adding build for Kotlin Gradle - Restructuring Java examples to v1 ap…
6e23b26
Correcting paths
480dd8b
Adding SNAPSHOT support and local capability for Maven. Testing using…
7a8dc16
Reviewed and updated against PR comments.
de08cbc
Merge branch 'main' into main
scottgerring bf843a7
Merging with Terraform additions from main branch
9a154dd
Un-commenting examples
e3c1cda
Un-commenting examples
e8ddb45
Adding validation step for IaC SAM
ec17480
Adding Terraform for Java projects IaC validator and linter
7d11fac
Adding additional projects for SAM validation and matrix approach
960992a
Merge branch 'main' into main
scottgerring 66327b1
Merge branch 'main' into main
jasoniharris 7c959c4
Merge branch 'main' into main
jeromevdl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
name: Validate IaC | ||
|
||
on: | ||
pull_request: | ||
branches: | ||
- main | ||
- v2 | ||
paths: | ||
- 'examples/**' | ||
jobs: | ||
linter: | ||
runs-on: ubuntu-latest | ||
strategy: | ||
matrix: | ||
project: ["sam", "gradle", "kotlin"] | ||
steps: | ||
- uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3 | ||
- name: Setup java JDK | ||
uses: actions/setup-java@5ffc13f4174014e2d4d4572b3d74c3fa61aeb2c2 # v3.11.0 | ||
with: | ||
distribution: 'corretto' | ||
java-version: 11 | ||
- name: Run SAM validator to check syntax of IaC templates - Java | ||
working-directory: examples/powertools-examples-core/${{ matrix.project }} | ||
run: | | ||
sam build | ||
sam validate --lint | ||
- name: Setup Terraform | ||
uses: hashicorp/setup-terraform@633666f66e0061ca3b725c73b2ec20cd13a8fdd1 #v2.0.3 | ||
- name: Run Terraform validator to check syntax of IaC templates and produce a plan of changes | ||
working-directory: examples/powertools-examples-core/terraform | ||
run: | | ||
mvn install | ||
terraform -version | ||
terraform init -backend=false | ||
terraform validate | ||
terraform plan | ||
- name: Setup Terraform lint | ||
uses: terraform-linters/setup-tflint@a5a1af8c6551fb10c53f1cd4ba62359f1973746f # v3.1.1 | ||
- name: Run Terraform lint to check for best practices, errors, deprecated syntax etc. | ||
working-directory: examples/powertools-examples-core/terraform | ||
run: | | ||
tflint --version | ||
tflint --init | ||
tflint -f compact |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.