docs: update documentation for aspectJ #1273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromevdl
changed the title
jeromevdl
force-pushed
the
doc/aspectj-plugin-configuration
branch
from
a02fa51 to
dbec008
Compare
|
We should also update the sam templates... https://github.com/aws/aws-sam-cli-app-templates/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #1271
Description of changes:
Added installation steps in core modules and described the aspectJ configuration for both Java 1.8 and 11+. Together with @scottgerring, we thought it would be better to use the old plugin (
org.codehaus.mojogroupId) for Java 1.8 and the new one (dev.aspectjgroupId) for Java 11+, instead of adding additional configuration and complexity (enforcing aspectj-rt 1.9.7)Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.