[fix] Decouple samples from the parent pom #1240
Conversation
|
@jeromevdl is it obvious to you why this build is failing off the top of your head? If not I will dive deep. Parameters example fails with: Which is the difference between Java 11 and Java 8. As far as I can tell from looking at the build, the whole thing should compile with Java 8, and when I build it locally with Corretto 1.8 it all works. Am I missing something obvious to you? |
This is exactly why I wanted to get samples autonomous... So that we can see this kind of things. This is the same error I had in end-to-end tests. You need to enforce the version 1.9.7 of aspecttools or aspectjrt, look at the e2e pom. |
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #1240 +/- ##
=========================================
Coverage 70.87% 70.87%
Complexity 541 541
=========================================
Files 72 72
Lines 2328 2328
Branches 254 254
=========================================
Hits 1650 1650
Misses 558 558
Partials 120 120 ☔ View full report in Codecov by Sentry. |
|
@jeromevdl have I missed anything?
You had a comment on the ticket that I've not done anything with that I might've missed the significance of:
|
@scottgerring, I was mentioning we should change the |
Co-authored-by: Jérôme Van Der Linden <117538+jeromevdl@users.noreply.github.com>
|
@jeromevdl cleaned up comments and changed github CI build to run |
|
You didn't like my comments ? maybe you can reformulate but I think we should say they don't really need the profiles, but just to take the dependency... |
…es-builds' into fix-decouple-examples-builds
my bad; I failed to push the commit resolving this yesterday before resolving the threads 🤦 I expanded on the profile xmldoc in each example like this: <!-- Use a profile to enforce AspectJ version 1.9.7 if we are Java 1.8 otherwise we'll get class
version mismatch issues. All subsequent Java releases build with the default AspectJ configuration
on the project.
Note:
- if you are running Java > 1.8, you can remove this profile altogether
- If you are running on Java 1.8, you should apply the aspectJ version here to the project, and remove
the profile.
--> |
Issue #, if available:
#1224
Description of changes:
The examples are two layers of maven module beneath the parent pom
parent --> examples --> [parameters / core / sqs / etc example projects]. At each layer a dependency upwards on the immediate parent pom is included - the example projects themselves have dependencies on the examples common parent, and the examples common parent has a dependency on the overall parent.This change keeps the module composition, but removes the parents. This means that all the dependencies have to be specified in each example project, but the advantage is that the example projects can be taken and used as-is - they are completely self contained.
By keeping the module composition going down, we also ensure that the build continues to work as you would expect - changing the interface of the parameters project for instance will break the parameters example and the build, giving the developer immediate feedback.
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.