Skip to content

chore: Metrics v2 always set namespace and service #807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

hjgraca
Copy link
Contributor

@hjgraca hjgraca commented Mar 7, 2025

Please provide the issue number

Issue number: #806

Summary

Changes

Please provide a summary of what's being changed

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@boring-cyborg boring-cyborg bot added area/metrics Core metrics utility tests labels Mar 7, 2025
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 7, 2025
@hjgraca hjgraca requested a review from leandrodamascena March 7, 2025 11:44
@hjgraca hjgraca linked an issue Mar 7, 2025 that may be closed by this pull request
@github-actions github-actions bot added the internal Maintenance changes label Mar 7, 2025
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.15%. Comparing base (98b19d3) to head (4fbada5).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #807      +/-   ##
===========================================
+ Coverage    73.94%   74.15%   +0.20%     
===========================================
  Files          210      210              
  Lines         8402     8411       +9     
  Branches       910      909       -1     
===========================================
+ Hits          6213     6237      +24     
+ Misses        1889     1881       -8     
+ Partials       300      293       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

sonarqubecloud bot commented Mar 7, 2025

@leandrodamascena leandrodamascena merged commit 21c1bfc into aws-powertools:develop Mar 7, 2025
8 checks passed
@hjgraca hjgraca deleted the fix/metrics-namespace-service-not-present branch March 7, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/metrics Core metrics utility internal Maintenance changes size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Metrics namespace and service should always be set
2 participants