Skip to content

Update to ACK runtime v0.48.0, code-generator v0.48.0 #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ack-bot
Copy link
Collaborator

@ack-bot ack-bot commented Jun 11, 2025

Update to ACK runtime v0.48.0, code-generator v0.48.0



NOTE:
This PR increments the release version of service controller from v1.3.0 to v1.3.1

Once this PR is merged, release v1.3.1 will be automatically created for sagemaker-controller

Please close this PR, if you do not want the new patch release for sagemaker-controller


stdout for make build-controller:

building ack-generate ... ok.
==== building sagemaker-controller ====
Copying common custom resource definitions into sagemaker
Building Kubernetes API objects for sagemaker
Generating deepcopy code for sagemaker
Generating custom resource definitions for sagemaker
Building service controller for sagemaker
Running GO mod tidy
Generating RBAC manifests for sagemaker
Running gofmt against generated code for sagemaker
Updating additional GitHub repository maintenance files
==== building sagemaker-controller release artifacts ====
Building release artifacts for sagemaker-v1.3.1
Generating common custom resource definitions
Generating custom resource definitions for sagemaker
Generating RBAC manifests for sagemaker

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot added the prow/auto-gen PRs related to prow auto generation automation label Jun 11, 2025
@ack-prow ack-prow bot requested review from ananth102 and surajkota June 11, 2025 00:01
Copy link

ack-prow bot commented Jun 11, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ack-bot
Once this PR has been reviewed and has the lgtm label, please assign michaelhtm for approval by writing /assign @michaelhtm in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -1,6 +1,4 @@
# See the OWNERS docs at https://go.k8s.io/owners

approvers:
- core-ack-team
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to look at why the OWNERS are being changed here.

@knottnt
Copy link
Contributor

knottnt commented Jun 11, 2025

/hold

@ack-prow ack-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 11, 2025
@knottnt
Copy link
Contributor

knottnt commented Jun 11, 2025

PR issues resolved in #309
/close

@ack-prow ack-prow bot closed this Jun 11, 2025
Copy link

ack-prow bot commented Jun 11, 2025

@knottnt: Closed this PR.

In response to this:

PR issues resolved in #309
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. prow/auto-gen PRs related to prow auto generation automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants