@aws-amplify/backend should inherit version bump of same kind from dependencies
#2042
Conversation
This reverts commit 65c6794.
|
| // eslint-disable-next-line import/no-extraneous-dependencies | ||
| import { ReleasePlan } from '@changesets/types'; |
There was a problem hiding this comment.
we should just add this package as dev dep.
| } | ||
| } | ||
| } | ||
| const versionTypeConverter = (version: VersionType): VersionTypeEnum => { |
There was a problem hiding this comment.
| const versionTypeConverter = (version: VersionType): VersionTypeEnum => { | |
| const convertVersionType = (version: VersionType): VersionTypeEnum => { |
function name should be verb-ish.
| maxVersion( | ||
| backendAuthVersion, | ||
| backendDataVersion, | ||
| backendFunctionVersion, | ||
| backendStorageVersion | ||
| ) |
There was a problem hiding this comment.
| maxVersion( | |
| backendAuthVersion, | |
| backendDataVersion, | |
| backendFunctionVersion, | |
| backendStorageVersion | |
| ) | |
| Math.max( | |
| backendAuthVersion, | |
| backendDataVersion, | |
| backendFunctionVersion, | |
| backendStorageVersion | |
| ) |
would this just work?
There was a problem hiding this comment.
yep, the function is unnecessary
Problem
@aws-amplify/backendsometimes does not properly inherit the right kind of version bump from its dependencies.Issue number, if available: #1693
Changes
check_changeset_completeness.tsto be split into functionscheck_changeset_completeness.tsthat check whether backend should be inheriting a version bump and whether it is currently inheriting the right kind of version bumpCorresponding docs PR, if applicable:
Validation
backendand its dependenciesbackend: none, dependencies have version bump ofminorbackend: minor, dependencies areminorornonebackend: patch, dependencies areminororpatchbackend: patch, no dependency versionsbackend: minor, one dependency ismajorChecklist
run-e2elabel set.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.