Skip to content

remove async_await feature gate #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2019
Merged

remove async_await feature gate #94

merged 1 commit into from
Aug 21, 2019

Conversation

yoshuawuyts
Copy link
Contributor

Removes the async_await feature gate, due to land in tomorrow's nightly (ref rust-lang/rust#63209 (comment)). Thanks!

Code used to remove feature gate

#!/bin/sh

files="$(fd .rs)"

for f in $files; do
  sed -i '/async_await/d' "$f"
done

cargo fmt -- --edition 2018

@yoshuawuyts yoshuawuyts force-pushed the remove-async_await-gate branch 2 times, most recently from d1fcc01 to 6892482 Compare August 21, 2019 00:16
@yoshuawuyts yoshuawuyts force-pushed the remove-async_await-gate branch 2 times, most recently from f520663 to 63ad786 Compare August 21, 2019 07:28
Signed-off-by: Yoshua Wuyts <yoshuawuyts@gmail.com>
@yoshuawuyts
Copy link
Contributor Author

Tests pass, I think this should be good to merge now!

@kpp kpp mentioned this pull request Aug 21, 2019
@kpp
Copy link
Contributor

kpp commented Aug 21, 2019

ping?

@skade
Copy link
Collaborator

skade commented Aug 21, 2019

I think this will fail on docs.rs...

@skade
Copy link
Collaborator

skade commented Aug 21, 2019

It will not fail on docs.rs anymore :)

@skade
Copy link
Collaborator

skade commented Aug 21, 2019

We also need to go through a-chat.

@skade
Copy link
Collaborator

skade commented Aug 21, 2019

I'm going to merge this for release prep.

@skade skade merged commit 70769d8 into master Aug 21, 2019
@ghost ghost deleted the remove-async_await-gate branch September 6, 2019 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants