io::copy: don't poll the reader again after eof while waiting for the writer to flush #894
+100
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoshuawuyts
approved these changes
Oct 15, 2020
|
@jbr Could you add a test for this, with some artificially constructed futures? The artificial read future can panic if it gets polled after EOF. |
jbr
force-pushed
the
dont-poll-after-eof-in-io-copy
branch
from
1c9e8c1 to
e94ff00
Compare
|
Confirmed locally that the test does in fact fail with the changes to async_std::io::copy stashed |
|
I do think it's worth figuring out if this was a bug previous to this commit. It was unspecified in documentation, and it's unclear if someone might be relying on the "continues to poll after eof" behavior, although that seems unlikely. I think this change is worth making either way, but the question is whether it's a breaking change or a bugfix |
jbr
force-pushed
the
dont-poll-after-eof-in-io-copy
branch
from
e94ff00 to
ae817ca
Compare
joshtriplett
approved these changes
Jun 20, 2022
Fishrock123
approved these changes
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not entirely sure if this is a bug or just unexpected behavior, but I thought I'd write a quick PR just in case. Prior to this PR, io::copy continues to poll the reader after it has already returned
Poll::Ready(Ok(0))in the situation where the writer's flush is not immediately Ready. This resulted in a bug with a Read implementation that expected not to be read again after it returned eof. Removing the after-eof polling might save someone else from some confusion