Implement an async version of ToSocketAddrs #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

14 commits merged into async-rs:master from DCjanus:master

Sep 4, 2019

Contributor

DCjanus commented Aug 18, 2019

Resolve #50

skade requested changes

View reviewed changes

src/net/addr.rs Outdated Show resolved Hide resolved

skade assigned ghost

ghost suggested changes

View reviewed changes

ghost left a comment

Thank you for the PR! I think we only need to replace the Output associated type with a "hack" that simulates async fn in traits.

src/net/addr.rs Outdated Show resolved Hide resolved

src/net/addr.rs Outdated Show resolved Hide resolved

Contributor Author

DCjanus commented Aug 20, 2019 •

edited

Loading

Force pushed to rebase on master

@stjepang Hi, after a long day, I've created a commit to replace std::net::ToSocketAddrs with async_std::net::ToSocketAddrs, would you mind review again. Thanks.

ghost commented Aug 26, 2019

Could you perhaps incorporate changes from https://github.com/DCjanus/async-std/pull/1 here? In particular, let's remove the new re-exports and move tests into the tests directory. At the same time, let's also delete unit tests that are not relevant to ToSocketAddrs.

skade approved these changes

View reviewed changes

kpp reviewed

View reviewed changes

src/net/addr.rs Outdated Show resolved Hide resolved

kpp reviewed

View reviewed changes

src/net/addr.rs Outdated Show resolved Hide resolved

kpp reviewed

View reviewed changes

tests/addr.rs Outdated Show resolved Hide resolved

kpp reviewed

View reviewed changes

tests/addr.rs Outdated Show resolved Hide resolved

kpp reviewed

View reviewed changes

tests/addr.rs Outdated Show resolved Hide resolved

kpp reviewed

View reviewed changes

tests/addr.rs Outdated Show resolved Hide resolved

kpp reviewed

View reviewed changes

tests/addr.rs Outdated Show resolved Hide resolved

kpp reviewed

View reviewed changes

src/net/addr.rs Outdated Show resolved Hide resolved

kpp reviewed

View reviewed changes

src/net/addr.rs Show resolved Hide resolved

kpp reviewed

View reviewed changes

tests/addr.rs Outdated Show resolved Hide resolved

kpp reviewed

View reviewed changes

src/net/addr.rs Outdated Show resolved Hide resolved

kpp reviewed

View reviewed changes

src/net/addr.rs Outdated Show resolved Hide resolved

kpp reviewed

View reviewed changes

src/net/addr.rs Outdated Show resolved Hide resolved

kpp reviewed

View reviewed changes

src/net/addr.rs Outdated Show resolved Hide resolved

kpp reviewed

View reviewed changes

src/net/addr.rs Outdated Show resolved Hide resolved

Collaborator

skade commented Sep 3, 2019

@stjepang is this ready to merge?

ghost suggested changes

View reviewed changes

ghost left a comment

Some small tweaks are needed and then we'll be ready to merge.

src/net/addr.rs Outdated Show resolved Hide resolved

src/net/addr.rs Outdated Show resolved Hide resolved

docs/src/tutorial/accept_loop.md Show resolved Hide resolved

DCjanus and others added 7 commits

September 5, 2019 01:09


          Implement an async version of ToSocketAddrs

2d39708


          fix documentation issue

4ad633e


          genius hack: pretending to be impl Future

7cba6c4


          replace std::net::ToSocketAddrs with async-std::net::ToSocketAddrs

8baf8df


          Move unit tests into the tests directory

e1b4935


          Stylistic changes

11cdff7


          Remove re-exports in async_std::net

815271b

DCjanus added 7 commits

September 5, 2019 01:09


          fix broken link

dc4d7bd


          some mirror changes

bfdf6ff


          remove unnecessary format

242cc9f


          migrate: std::net::ToSocketAddrs -> async_std::net::ToSocketAddrs

63c2c75


          fix typo(tutorial)

ff40561


          remove unnecessary type bound

d2c61b6


          lifetime for future

6db0085

ghost approved these changes

View reviewed changes

ghost left a comment

This looks good to me now. Thanks for driving the PR to completion

ghost commented Sep 4, 2019

bors r+

bors bot added a commit that referenced this pull request


          Merge #74

8898d29

74: Implement an async version of ToSocketAddrs r=stjepang a=DCjanus

Resolve #50 

Co-authored-by: DCjanus <dcjanus@dcjanus.com>
Co-authored-by: Stjepan Glavina <stjepang@gmail.com>

ghost merged commit 238a3c8 into async-rs:master

tomaka mentioned this pull request

Don't use a thread pool for DNS resolution libp2p/rust-libp2p#1235

Closed

moh-eulith pushed a commit to moh-eulith/async-std that referenced this pull request


          Merge pull request async-rs#74 from smol-rs/deps

48e672d

Update dev-dependencies

This pull request was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet