small typos and edits in first few pages #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On apostrophes, I think that's what the markdown implementation does... Or can you point me at a line that does that? |
|
Fixed a merge problem. |
I don't mean in the rendered output (from the markdown implementation), I mean in the source, eg: https://github.com/async-rs/async-std/blame/master/docs/src/concepts/futures.md#L108 |
|
Right, I see. That's a bug, it only occurs at 3 places. I'll fix that, thanks! |
Merged
jamesmunns
approved these changes
Aug 16, 2019
|
Thanks! |
moh-eulith
pushed a commit
to moh-eulith/async-std
that referenced
this pull request
Mar 31, 2022
Update dev-dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small typos, markdown lints and other wording tweaks I noticed while reading. Hopefully nothing controversial.
Just a few pages in so far; I'll add more as I go.
One question: the current content uses "directional" apostrophes, it’s vs it's, that gets caught by my spell-checker. Before I go changing them, is this deliberate / preferred?