Add stream timeout #348
Merged
Add stream timeout #348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoshuawuyts
reviewed
Oct 16, 2019
src/stream/stream/timeout.rs
Outdated
| #[cfg_attr(feature = "docs", doc(cfg(unstable)))] | ||
| #[cfg(any(feature = "unstable", feature = "docs"))] | ||
| #[derive(Clone, Copy, Debug, Eq, PartialEq)] | ||
| pub struct TimeoutError; |
There was a problem hiding this comment.
Should we export this too?
There was a problem hiding this comment.
Also, this type should not be constructible by end-users. To do prevent users from being able to create instances of TimeoutError, do:
pub struct TimeoutError {
_private: (),
}
k-nasa
force-pushed
the
add_stream_timeout
branch
from
b6edd12 to
5ef5e5b
Compare
k-nasa
force-pushed
the
add_stream_timeout
branch
from
5ef5e5b to
10f32ca
Compare
yoshuawuyts
reviewed
Oct 16, 2019
yoshuawuyts
reviewed
Oct 16, 2019
yoshuawuyts
reviewed
Oct 16, 2019
ghost
previously requested changes
Oct 16, 2019
src/stream/stream/mod.rs
Outdated
| "#] | ||
| #[cfg(any(feature = "unstable", feature = "docs"))] | ||
| #[cfg_attr(feature = "docs", doc(cfg(unstable)))] | ||
| fn timeout(self, dur: Duration) -> TimeoutStream<Self> |
There was a problem hiding this comment.
We don't add the "Stream" suffix to stream types so this should be just Timeout<Self>. See other similar stream types for reference (e.g. Empty, Repeat, Chain).
Co-Authored-By: Yoshua Wuyts <yoshuawuyts+github@gmail.com>
|
I fixed it. |
|
@yoshuawuyts @stjepang |
yoshuawuyts
approved these changes
Oct 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #340
Currently, the process that times out cannot be tested.
Is there any stream processing that takes time easily?