add Stream::last #347
Merged
add Stream::last #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Struggling with the associated type, pinning and how to move/copy LastFuture.last.
still problems assigning the new value to self.last
starsheriff
commented
Oct 16, 2019
ghost
reviewed
Oct 16, 2019
|
Looks like this just needs a |
ghost
reviewed
Oct 16, 2019
src/stream/stream/mod.rs
Outdated
| "#] | ||
| fn last( | ||
| self, | ||
| ) -> impl Future<Output = Option<Self::Item>> + '_ [LastFuture<Self, Self::Item>] |
There was a problem hiding this comment.
Suggested change
| ) -> impl Future<Output = Option<Self::Item>> + '_ [LastFuture<Self, Self::Item>] | |
| ) -> impl Future<Output = Option<Self::Item>> [LastFuture<Self, Self::Item>] |
There was a problem hiding this comment.
right, the lifetime is not needed. I got a bit lost in the type signature I guess 😬
ghost
reviewed
Oct 16, 2019
src/stream/stream/mod.rs
Outdated
| "#] | ||
| fn last( | ||
| self, | ||
| ) -> impl Future<Output = Option<Self::Item>> + 'static [LastFuture<Self, Self::Item>] |
There was a problem hiding this comment.
The + 'static is not necessary (doesn't have an effect in this context) and we don't use it other similar methods :)
Suggested change
| ) -> impl Future<Output = Option<Self::Item>> + 'static [LastFuture<Self, Self::Item>] | |
| ) -> impl Future<Output = Option<Self::Item>> [LastFuture<Self, Self::Item>] |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have troubles getting the assignment to
self.lastworking. I am not so familiar with pinning, so any hint would be appreciated 😬Ref #129