Skip to content

impl Stream::take_while adapter #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
4 commits merged into from
Oct 15, 2019
Merged

impl Stream::take_while adapter #332

4 commits merged into from
Oct 15, 2019

Conversation

starsheriff
Copy link
Contributor

Hei,
my first take on adding a stream adapter.

For issue #129

ghost
ghost reviewed Oct 15, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! I have just one nit :)

ghost
ghost approved these changes Oct 15, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ghost ghost merged commit 6be8467 into async-rs:master Oct 15, 2019
@starsheriff starsheriff deleted the take_while branch October 15, 2019 08:03
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@starsheriff