Fixes feature flag used in generating the docs in the README #278
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought I'd take a stab at fixing at this #82, but I ran into a few errors following the instruction in the README.md
The first error and one that is addressed in this pull request is that the feature flag used to generate the docs is incorrect- it should be
docs
and notdocs.rs
Perhaps additionally, it should be
--features docs,unstable
as it is in.travis.yml
. Should I add that to the README? https://github.com/async-rs/async-std/blob/master/.travis.yml#L53Lastly, I had to use the
+nightly
flag to get it to the docs and example to run. Should I add this or is it assumed that the user would have this configured somewhere?Thanks!