Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
IntoFuture
trait, wihch @Nemo157 pointed out would be useful for implementing the "async builder" pattern we used when building Surf.In the RFC2394 async_await it's also stated that
await
should callIntoFuture
under the hood.This PR doesn't add that functionality to
await
, but does have the right shape it should take, which allows people to start implementingIntoFuture
so that later it will "just work".cc/ @withoutboats, is what I've said so far about
IntoFuture
still accurate? I didn't see any mentions that this had been changed in the stabilization report, so does that mean that it means this simply has not been implemented yet?Screenshot