Expose fs::create_dir_all #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! That indeed looks like a mistake. Could you also add a line to the CHANGELOG? |
skade
reviewed
Aug 26, 2019
CHANGELOG.md
Outdated
| @@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://book.async.rs/overview | |||
| - Many small changes in the book, mostly typos | |||
| - Documentation fixes correcting examples | |||
| - Now works with recent nightly with stabilised async/await (> 2019-08-21) | |||
| - Expose `fs::create_dir_all` | |||
There was a problem hiding this comment.
Ha, sorry ;). It should go in the "Unreleased" section, 0.99.4 has already been released.
There was a problem hiding this comment.
Woops! The headings threw me for a loop there.
dfrankland
force-pushed
the
expose-fs-create_dir_all
branch
from
a479204 to
2fc6610
Compare
|
Thanks, I'll wait for CI to finish. |
skade
added
the
accepted
|
And done, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this function was accidentally unimported originally, but this PR fixes that 😄