Fix file EOF to not be permanent: reading again should give new data #1030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go back to the idle mode when returning EOF, so that the next read will make another attempt to read from the file in case the file grew.
joshtriplett
force-pushed
the
file-eof-should-not-be-permanent
branch
from
858b24b to
dfdf56c
Compare
joshtriplett
changed the title
yoshuawuyts
approved these changes
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
async_std::fs::Filecurrently has a bug that makes EOF a permanent condition:once the
Filehas encountered EOF, it will continue to return EOF even if newdata gets added to the file.
Discovered when trying to convert some code from
smoltoasync_std. Thecode depends on having multiple
Fileobjects referring to the same disk file,appending to one, and expecting the other to be able to read the new data.
Fix the
Fileimplementation to address this, and add a test to verify this behavior.