[docs] clearer variable name for broker_handle #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvkemp
changed the title
zvkemp
force-pushed
the
clean-shutdown-doc-fixes
branch
from
853cc9e to
8bc58cf
Compare
ghost
suggested changes
Aug 23, 2019
docs/src/tutorial/clean_shutdown.md
Outdated
| @@ -60,7 +60,7 @@ async fn broker(mut events: Receiver<Event>) -> Result<()> { | |||
| Entry::Vacant(entry) => { | |||
| let (client_sender, client_receiver) = mpsc::unbounded(); | |||
| entry.insert(client_sender); | |||
| let handle = spawn_and_log_error(client_writer(client_receiver, stream)); | |||
| let handle = client_writer(client_receiver, stream); | |||
There was a problem hiding this comment.
I think it'd be best to still spawn the task here, otherwise futures will not execute in parallel.
If we just collect these futures into a Vec and then await them at line 72, they will execute serially. But if we spawn them first, they will execute in the background on other threads, and at line 72 we just await these tasks to complete.
zvkemp
force-pushed
the
clean-shutdown-doc-fixes
branch
from
8bc58cf to
d22ad68
Compare
|
Thanks @stjepang . Looks like one issue was addressed in another PR; I've rebased and reduced this to a single change. |
zvkemp
changed the title
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
broker_handleas a variable name to avoid overloading thebrokerfunctionkeep theResultfromclient_writerinwriters(makes the loop withwriter.await?;work correctly)returnResultfrombrokersin the final code example