Retry on transient failures during artifact upload #486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
commented
Jan 8, 2025
Comment on lines
+483
to
+484
| { | ||
| let mut fs = vec![]; |
There was a problem hiding this comment.
~unchanged, needed to put this in a block to satisfy the borrow checker with borrow of raw_client in fs.
Gankra
approved these changes
Jan 8, 2025
| } | ||
|
|
||
| let file_data = Bytes::copy_from_slice(&std::fs::read(dist_dir.join(&source))?); | ||
| let retry_policy = ExponentialBackoff::builder().build_with_max_retries(5); |
There was a problem hiding this comment.
5 feels high to me but very weak feeling about it
There was a problem hiding this comment.
Yeah the default recommendation is three but we're uploading a ton of artifacts and GitHub is really flaky so I figured I'd start high.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to fix transient release failures, e.g, https://github.com/astral-sh/python-build-standalone/actions/runs/12637445294/job/35213894154