This repository was archived by the owner on Jul 27, 2023. It is now read-only.
Add Decorator
node
#7
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
Decorator
node. The node wraps an expression and its range includes the@
.Having a dedicated node for
Decorator
s simplifies the implementation of the Formatter when handling leading comments:The leading comment should be attached to the whole decorator and not just the expression coming after the
@
. It's also necessary that we distinguish between comments attached to the decorator vs comments attached to the decorator's expression:This is straightforward when the decorator and the expression are different nodes.
This change has the added benefit that the Linter now gets the full range of the decorator. For example, we have fixes that replace remove the whole decorator but they incorrectly assume that its safe to subtract 1 from the start (offset of the
@
). However, this doesn't account for:which is valid python