RedirectToAction causes InvalidOperationException

[develax]

I'm using ASP.NET MVC Core 2.0.7 and trying to make a simple redirect via

return RedirectToAction(nameof(EditPost), new { post.Id });

which ends with the exception:

InvalidOperationException: Invalid non-ASCII or control character in header: 0x0441

I found some similar issues here, but they are related to Redirect (not RedirectToAction) and they all are closed.

P.S.
The same exception is thrown when using RedirectToRoute:

return RedirectToRoute(RouteNames.PostsAdminRoute, new { action = nameof(EditPost), post.Id });

[kichalla]

This issue seems to be similar to aspnet/Routing#513. This was fixed for our latest 'preview' release but hasn't be back ported yet to the '2.0.*' version yet. I filed dotnet/aspnetcore#3087 to keep track of it.

@develax Could you share how your Startup.cs looks like? Also you could try the following workaround and see if it fixes your issue?

Try adding the following service as the last one in your ConfigureServices method:

services.AddSingleton(UrlEncoder.Default);

[develax]

@kichalla

services.AddSingleton(UrlEncoder.Default);

thank you, it looks like it healed my problem! What does it do in particular, wasn't it default by default?

My Startup.cs is not very compact to show it whole, I guess you want to see this part:

public void ConfigureServices(IServiceCollection services)
{
    _services = services
        .Configure<RouteOptions>(options => options.LowercaseUrls = true) // doesn't work for unicode :(
        .Configure<WebEncoderOptions>(opt => opt.TextEncoderSettings = new TextEncoderSettings(UnicodeRanges.All)) // Workaround for the issue: https://github.com/aspnet/HttpAbstractions/issues/315
        .ConfigureSection<ConnectionStrings>(_configRoot);

    services
        .AddIdentity<AppUser, AppRole>(op =>
        {
            op.User = new UserOptions
            {
                RequireUniqueEmail = true
            };
            op.Password = new PasswordOptions
            {
                RequireDigit = false,
                RequiredLength = 5,
                RequireLowercase = false,
                RequiredUniqueChars = 1,
                RequireNonAlphanumeric = false,
                RequireUppercase = false
            };
        })
        .UseMyIdentityStoreAdapter()
        .AddDefaultTokenProviders();

    // https://github.com/aspnet/Identity/issues/1414
    services.ConfigureApplicationCookie(opt =>
    {
        opt.LoginPath = new PathString($"/{Aliases.Account._ControllerAlias}/{Aliases.Account.Login}");
        opt.ReturnUrlParameter = "returnUrl";
    });

    services.AddMvc(opt =>
    {
        opt.Filters.Add(typeof(SetActionViewNameFromActionNameAttributeFilter));
        opt.Filters.Add(typeof(RemoveStringsSpaceRedundancy));
    });

    services
        .AddSingleton(_configRoot)
        .AddSingleton<IServiceConfiguration, ServiceConfiguration>()
        .AddSingleton<IIndexModelService, IndexModelService>()
        .AddSingleton<IPicturesService, PicturesService>()
        .AddSingleton<IPostsAdminService, PostsAdminService>()
        .AddSingleton<IPostsService, PostsService>();

    // Setting authorization policies.
    AdminUserInfo adminUserInfo = AdminUserInfo.Create(_configRoot);
    string adminRoleName = adminUserInfo.RoleName;

    if (adminRoleName == null)
        throw new KeyNotFoundException($"Parameter '{nameof(adminUserInfo.RoleName)}' is not found.");

    services.AddAuthorization(
        opt =>
        {
            opt.AddPolicy(PolicyNames.AdminPolicyName, policy => policy.RequireRole(adminRoleName));
        }
    );
}

[kichalla]

What does it do in particular, wasn't it default by default?

Routing related components (which MVC depends on generating links) must in general always depend on UrlEncoder.Default as not all characters are valid in a url and they need to be encoded in a certain way. These components were depending on DI to get the UrlEncoder and since users have the option of changing encoding settings via WebEncoderOptions, a setting which could be valid for let's say HtmlEncoder might not be for UrlEncoder. So we fixed Routing to always use UrlEncoder.Default and not depend on DI to get it.

[develax]

@kichalla thank you for the explanation!
I use Cyrillic in URLs via ActionName attribute

    [ActionName(Aliases.PostsAdmin.EditPost)]
    public async Task<IActionResult> EditPost(int id) { ... }

so, that was likely the reason.

[develax]

Having added this workaround
AddSingleton(UrlEncoder.Default)
I'm getting the same error with the method
public virtual RedirectResult Redirect(string url);