Skip to content
This repository was archived by the owner on Nov 20, 2018. It is now read-only.
This repository was archived by the owner on Nov 20, 2018. It is now read-only.

SessionCollectionExtensions.SetInt and GetInt don't follow the design guidelines #256

Closed
@justinvp

Description

@justinvp

SessionCollectionExtensions has the following two methods:

public static class SessionCollectionExtensions
{
    public static void SetInt(this ISessionCollection session, string key, int value);
    public static int? GetInt(this ISessionCollection session, string key);

    ...
}

These method names do not follow the Framework Design Guidelines:

DO use a generic CLR type name, rather than a language-specific name, in the rare cases when an identifier has no semantic meaning beyond its type.

For example, a method converting to Int64 should be named ToInt64, not ToLong (because Int64 is a CLR name for the C#-specific alias long).

These methods should be named SetInt32 and GetInt32.

/cc @terrajobst

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions