This repository was archived by the owner on Nov 20, 2018. It is now read-only.
This repository was archived by the owner on Nov 20, 2018. It is now read-only.
SessionCollectionExtensions.SetInt and GetInt don't follow the design guidelines #256
Closed
Description
SessionCollectionExtensions
has the following two methods:
public static class SessionCollectionExtensions
{
public static void SetInt(this ISessionCollection session, string key, int value);
public static int? GetInt(this ISessionCollection session, string key);
...
}
These method names do not follow the Framework Design Guidelines:
√ DO use a generic CLR type name, rather than a language-specific name, in the rare cases when an identifier has no semantic meaning beyond its type.
For example, a method converting to
Int64
should be namedToInt64
, notToLong
(becauseInt64
is a CLR name for the C#-specific aliaslong
).
These methods should be named SetInt32
and GetInt32
.
/cc @terrajobst