Flip NoPGO to PGO in Stage1 #1810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eerhardt you own these, better if you know what is necessary here |
eerhardt
approved these changes
Mar 13, 2023
There was a problem hiding this comment.
This would make sense why we were getting the same results between Stage1 and Stage1NoPgo.
Note that our NativeAOT goal is "within 5% RPS of the default CoreCLR", so we won't be comparing NativeAOT to these, but it would be beneficial to get numbers on enabling PGO.
It seems to be overdone on arm already 😄 |
|
Yeah - we don't know why/how NativeAOT is getting better RPS numbers on Ampere Linux. If you have any insights, they would be appreciated. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These
No PGOdidn't make any sense - PGO is not enabled by default.cc @sebastienros