Use .NET SDK in two test projects #371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougbu
requested review from
TanayParikh,
MackinnonBuck,
javiercn and
a team
dougbu
force-pushed
the
dougbu/Newtonsoft.Json.part4
branch
from
b7a1be2 to
2cdd25b
Compare
dougbu
force-pushed
the
dougbu/Newtonsoft.Json.part5
branch
from
e0ccddc to
3a910b7
Compare
dougbu
force-pushed
the
dougbu/Newtonsoft.Json.part5
branch
from
3a910b7 to
0e80639
Compare
wtgodbe
reviewed
Nov 28, 2022
wtgodbe
approved these changes
Nov 28, 2022
|
@wtgodbe and other reviewers, suggest having another look because I needed to change a fair amount to get things working end-to-end. |
This was referenced Dec 11, 2022
- for now, unable to target `netcoreapp2.1` in NetCore.Test project - Microsoft.Net.Http is not compatible - System.Net.Http types have different identities, causing compilation failures - switch to use `dotnet vstest` for any .NET Core assemblies (just one currently) - can use `Xunit` target for all .NET Framework assemblies - make XunitXml.TestLogger available for .NET Core App testing - use above test logger in repo-level testing - integrate w/ tests that use the `Xunit` target - don't import from xunit.msbuild.runner when targeting .NET Core; not needed - add `$(CopyLocalLockFileAssemblies)` to these (now both .NET SDK) test projects - xUnit assemblies were not copied (when they should have been) w/o this
- allows reference in .NET SDK test projects
- rename WebStack.xunit.targets -> WebStack.testing.targets - rename `Xunit` target -> `TestAssembly` - move `dotnet vstest` use into new target - handle exit codes more consistently
dougbu
force-pushed
the
dougbu/Newtonsoft.Json.part5
branch
from
bd9ec79 to
82f520b
Compare
wtgodbe
reviewed
Dec 12, 2022
...stem.Net.Http.Formatting.NetStandard.Test/System.Net.Http.Formatting.NetStandard.Test.csproj
Show resolved
Hide resolved
wtgodbe
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use .NET SDK in NetCore.Test project
netcoreapp2.1in NetCore.Test projectdotnet vstestfor any .NET Core assemblies (just one currently)Xunittarget for all .NET Framework assembliesXunittarget$(CopyLocalLockFileAssemblies)to these (now both .NET SDK) test projectsUse .NET SDK in Microsoft.TestCommon
netcoreapp2.1before