Use Newtonsoft.Json.Bson except in NetCore projects #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougbu
requested review from
JamesNK,
javiercn,
MackinnonBuck,
TanayParikh and
a team
TanayParikh
reviewed
Nov 23, 2022
Comment on lines
-265
to
+268
| #if NEWTONSOFTJSON10 // Json.NET 10's Bson package calculates the path in some exceptions differently. | ||
| string expectedPath = "Value"; | ||
| #else | ||
| #if NETFX_CORE // Separate Bson package (not yet used in NETCore project) calculates the path in exceptions differently | ||
| string expectedPath = string.Empty; | ||
| #else | ||
| string expectedPath = "Value"; |
There was a problem hiding this comment.
Just to confirm, this inversion in logic was intentional?
There was a problem hiding this comment.
Yes. We have 3 Http.Formatting projects in src: NetCore for Profile259 (which is supposed to be similar to netstandard1.3 but is actually a superset in some ways), NetStandard for netstandard2.0, and "regular" for .NET Framework. Previously only the NetStandard project defined NEWTONSOFTJSON10 and used the Json.Bson package. Now all but the NetCore project uses Json.Bson. That project defines NETFX_CORE.
TanayParikh
approved these changes
Nov 23, 2022
JamesNK
approved these changes
Nov 24, 2022
- avoid obsolete `BsonReader` and `BsonWriter` classes - use `NETFX_CORE` for remaining legacy case (for now) - remove `NEWTONSOFTJSON10` define; need only `NETFX_CORE` now
dougbu
force-pushed
the
dougbu/Newtonsoft.Json.part4
branch
from
b7a1be2 to
2cdd25b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BsonReaderandBsonWriterclassesNETFX_COREfor remaining legacy case (for now)NEWTONSOFTJSON10define; need onlyNETFX_COREnow