Add Bilibili provider #1044
Merged
Add Bilibili provider #1044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/AspNet.Security.OAuth.Bilibili/AspNet.Security.OAuth.Bilibili.csproj
Show resolved
Hide resolved
test/AspNet.Security.OAuth.Providers.Tests/Bilibili/BilibiliTests.cs
Outdated
Show resolved
Hide resolved
src/AspNet.Security.OAuth.Bilibili/BilibiliAuthenticationHandler.cs
Outdated
Show resolved
Hide resolved
src/AspNet.Security.OAuth.Bilibili/BilibiliAuthenticationHandler.cs
Outdated
Show resolved
Hide resolved
src/AspNet.Security.OAuth.Bilibili/BilibiliAuthenticationHandler.cs
Outdated
Show resolved
Hide resolved
src/AspNet.Security.OAuth.Bilibili/BilibiliAuthenticationHandler.cs
Outdated
Show resolved
Hide resolved
src/AspNet.Security.OAuth.Bilibili/BilibiliAuthenticationHandler.cs
Outdated
Show resolved
Hide resolved
src/AspNet.Security.OAuth.Bilibili/BilibiliAuthenticationHandler.cs
Outdated
Show resolved
Hide resolved
src/AspNet.Security.OAuth.Bilibili/AspNet.Security.OAuth.Bilibili.csproj
Outdated
Show resolved
Hide resolved
src/AspNet.Security.OAuth.Bilibili/BilibiliAuthenticationHandler.cs
Outdated
Show resolved
Hide resolved
martincostello
approved these changes
Mar 27, 2025
There was a problem hiding this comment.
LGTM, but pinging @kevinchalet for a review after the conversation in the other PR recently.
kevinchalet
reviewed
Mar 27, 2025
src/AspNet.Security.OAuth.Bilibili/BilibiliAuthenticationHandler.cs
Outdated
Show resolved
Hide resolved
src/AspNet.Security.OAuth.Bilibili/BilibiliAuthenticationHandler.cs
Outdated
Show resolved
Hide resolved
src/AspNet.Security.OAuth.Bilibili/BilibiliAuthenticationHandler.cs
Outdated
Show resolved
Hide resolved
src/AspNet.Security.OAuth.Bilibili/BilibiliAuthenticationHandler.cs
Outdated
Show resolved
Hide resolved
src/AspNet.Security.OAuth.Bilibili/BilibiliAuthenticationHandler.cs
Outdated
Show resolved
Hide resolved
src/AspNet.Security.OAuth.Bilibili/BilibiliAuthenticationHandler.cs
Outdated
Show resolved
Hide resolved
kevinchalet
reviewed
Mar 30, 2025
src/AspNet.Security.OAuth.Bilibili/BilibiliAuthenticationHandler.cs
Outdated
Show resolved
Hide resolved
|
Hi @martincostello, Is there anything I still need to work on? |
|
Hi @kevinchalet May I ask if I have omitted some details and failed to commit them? |
|
When can this PR be released? @martincostello @kevinchalet |
kevinchalet
approved these changes
May 20, 2025
src/AspNet.Security.OAuth.Bilibili/BilibiliAuthenticationHandler.cs
Outdated
Show resolved
Hide resolved
|
Once Kévin's single comment is addressed, once I get the time free I'll merge this and start to cut a new release. |
src/AspNet.Security.OAuth.Bilibili/BilibiliAuthenticationHandler.cs
Outdated
Show resolved
Hide resolved
Tweak comment.
src/AspNet.Security.OAuth.Bilibili/AspNet.Security.OAuth.Bilibili.csproj
Outdated
Show resolved
Hide resolved
Update baseline version for package.
Bump version to 9.4.0.
|
Thanks for your patience @Loongle - this provider is now available from NuGet.org: https://www.nuget.org/packages/AspNet.Security.OAuth.Bilibili/ |
|
Thank you for the merge. I have received the update from Nuget, it has been deployed to our production environment and the test has been successful. Thank you all again.❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Bilibili provider
Screenshots translated by Microsoft
https://openhome.bilibili.com/doc/4/aac73b2e-4ff2-b75c-4c96-35ced865797b#h2-u63A5u5165u6D41u7A0Bu8BE6u7EC6u4ECBu7ECD