Skip to content

Move react to a peerDependency, and webpack to a dev dependency #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2020
Merged

Move react to a peerDependency, and webpack to a dev dependency #16

merged 1 commit into from
Jul 2, 2020

Conversation

ehaynes99
Copy link

Fixes #15

ashishd751
ashishd751 approved these changes Jul 2, 2020
View reviewed changes
Copy link
Owner

@ashishd751 ashishd751 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! You can go ahead and merge :)

@ehaynes99
Copy link
Author

I don't actually have write access to do that, but you can whenever you like. ;)

@ashishd751 ashishd751 merged commit 1bd2ae4 into ashishd751:master Jul 2, 2020
@ashishd751
Copy link
Owner

Done brother 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashishd751 ashishd751 ashishd751 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

react should be a peerDependency
2 participants
@ehaynes99 @ashishd751