Skip to content

WiFiS3 add Ping #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

WiFiS3 add Ping #47

wants to merge 3 commits into from

Conversation

paulvha
Copy link
Contributor

@paulvha paulvha commented Feb 16, 2024

second attempt to get Ping added. This also requires a change to the Core (submitted separately)

regards,
Paul

@JAndrassy
Copy link
Contributor

one AT command would do. in the ESPPing library the version with the host name does hostByName and then calls the IP version.
hostByName as first attempts to parse the string as IP address (so it does the same as your PINGIP handler)

@paulvha
Copy link
Contributor Author

paulvha commented Feb 16, 2024

I wanted to provide BOTH options in the user in the sketch either to provide a hostname OR provide an IP. Indeed I could have added an indicator (boolean) to indicate that the provided argument is a hostname or IP-address. But I rather keep it simple..

@JAndrassy
Copy link
Contributor

JAndrassy commented Feb 16, 2024

loat CWifi::ping(IPAddress ip, unsigned int count) {
/* -------------------------------------------------------------------------- */
  return ping(ip.toString().c_str(), count);
}

will work OK in the WiFiS3 library

@paulvha
Copy link
Contributor Author

paulvha commented Feb 16, 2024 via email

@JAndrassy
Copy link
Contributor

JAndrassy commented Feb 17, 2024

please. the ping function used in my snippet is your ping(host, count). only one PING AT command is need.

@paulvha
Copy link
Contributor Author

paulvha commented Feb 17, 2024

change applied and pull request updated.

will also update the bridge pull request to only _PINGNAME in commands

regards,
Paul

@pennam
Copy link
Contributor

pennam commented Nov 25, 2024

@paulvha thanks for your contribution. I've took your commits and reworked a bit to implement the ping functionality using esp idf to avoid the inclusion of third party library.

Superseded by #65

@pennam pennam closed this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants