Skip to content

Initial set up #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2021
Merged

Initial set up #1

merged 1 commit into from
Mar 31, 2021

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Mar 14, 2021 •
edited
Loading

@per1234
Copy link
Contributor Author

per1234 commented Mar 14, 2021 •
edited
Loading

The "Check Markdown" workflow failure is expected:

  1. No RFCs have been added, so the link to the RFCs subfolder is broken.
  2. It's in a private repository, so the link to the pull request tracker is broken due to the link checker not having access token.

@per1234 per1234 requested a review from rsora March 15, 2021 08:39
silvanocerza
silvanocerza reviewed Mar 16, 2021
View reviewed changes
Copy link

@silvanocerza silvanocerza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. 👍

@per1234 per1234 force-pushed the development branch 3 times, most recently from 352bfb1 to 09aee79 Compare March 20, 2021 04:04
rsora
rsora suggested changes Mar 24, 2021
View reviewed changes
Copy link

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that all the content in this readme is pretty clean and clear
I left only a suggestion to explain better that the contributor has several options to contribute to our projects, depending on the level of impact and involvement required.

@per1234 per1234 force-pushed the development branch 4 times, most recently from a19e3fb to 69b0e0b Compare March 25, 2021 04:04
rsora
rsora suggested changes Mar 30, 2021
View reviewed changes
Copy link

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@per1234 I added a couple of comments to clarify that an issue is always needed before starting an RFC. I added a section called "Implementation" to describe what happens after an RFC is approved.

As usual, you can adjust the wording as you prefer 👍

@per1234 per1234 merged commit 5eae124 into main Mar 31, 2021
@per1234 per1234 deleted the development branch March 31, 2021 14:15
@per1234 per1234 self-assigned this Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvanocerza silvanocerza silvanocerza approved these changes

@rsora rsora rsora approved these changes

Assignees

@per1234 per1234

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@per1234 @silvanocerza @rsora