Make initial import of Go release system templates #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per1234
added
type: enhancement
silvanocerza
approved these changes
Jun 18, 2021
This is the initial, unmodified import of the release and nightly build system: - https://github.com/arduino/arduino-cli/blob/d4f31dfe43bd9fe67c80208270244b3421a913fe/.github/workflows/nightly.yaml - https://github.com/arduino/arduino-cli/blob/d4f31dfe43bd9fe67c80208270244b3421a913fe/.github/workflows/release.yaml - https://github.com/arduino/arduino-cli/blob/d4f31dfe43bd9fe67c80208270244b3421a913fe/DistTasks.yml - https://github.com/arduino/arduino-cli/blob/d4f31dfe43bd9fe67c80208270244b3421a913fe/Taskfile.yml (relevant lines) - https://github.com/arduino/arduino-cli/blob/d4f31dfe43bd9fe67c80208270244b3421a913fe/gon.config.hcl
These will make it easy to find the template to allow syncs in either direction.
This will make it easy for contributors to discover information about the purpose and usage of the file.
All the other template workflows use the name "Checkout repository" for their checkout step, so this one should as well for consistency.
GitHub Actions workflow artifacts lose their executable permissions. The previous comment anticipated that this would be resolved by the 2.x release of actions/download-artifact. However, that release came without any change to the situation, leaving the comment outdated and potentially confusing.
The previous name was all but worthless and made an already cryptic step even more indecipherable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not the final state of the templates. I decided that it will be easier to review if I submit the required functional changes to integrate the improvements from Arduino Lint's system and facilitate the use of the assets as templates as separate PRs.